Bug #190

avatar

Sudo prompt mixed up a bit

Added by Jeff Forcier 56 days ago. Updated 25 days ago.

Status:Done Start:07/14/2010
Priority:Normal Due date:
Assigned to:avatarJeff Forcier % Done:

0%

Category:UI
Target version:1.0

Description

Example of sudo password prompt when env.password is non-empty:

[jforcier@192.168.0.180] out: sudo password: [Enter for previous]

On master, it looks like this instead:

Password for jforcier@localhost [Enter for previous]: 

Obviously things have to change somewhat do deal with the fact that we’re printing the “real” sudo prompt instead of our own, thus the host prefix. However, note how the colon has been swapped around — that’s kind of ugly.

I'm not sure there’s a way to fix this given that the sudo password: part is “real” stdout/stderr, and the [Enter for previous] part is printed by the local Python. May be as simple as changing env.sudo_prompt to drop the colon and add it into the local Python side of things; but make sure that works with the various combinations of settings re: pty/combine_streams/etc.


Related issues

related to Feature #7 Improved prompt detection and passthrough Done 07/20/2009
related to Bug #209 Some password prompts no longer specify the user Done 08/06/2010

History

Updated by Jeff Forcier 25 days ago

avatar
  • Status changed from New to Done

As a result of changes in #209, this is no longer an issue.

Also available in: Atom